[Libguestfs] [PATCH] New API: resize2fs_P

Maxim Perevedentsev mperevedentsev at virtuozzo.com
Wed Oct 14 09:53:26 UTC 2015


> There's a case for multiplying the return size by the block size of
> the filesystem, thus returning the size in bytes.  It might make the
> API easier to use.  Not sure how hard that is, or whether it actually
> makes the API easier to use.
>
> Rich.
This multiplication may confuse users who got used to "normal" resize2fs 
-P behavior (blocks) due to the name of API command.
I'm going to implement similar functionality for other filesystems 
(ntfs, btrfs, xfs).
I think we should preserve original command's behavior (well-documented, 
obviously!) and leave the conversion between blocks, megabytes, etc to user.
Maybe (later) we could implement aggregated call (getMinFsSizeInBytes()) 
to perform all this conversions.

-- 
Your sincerely,
Maxim Perevedentsev




More information about the Libguestfs mailing list