[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH v2 1/4] v2v: consolidate virtio-win file copying



On Wed, Oct 14, 2015 at 02:26:22PM +0300, Roman Kagan wrote:
> On Tue, Oct 13, 2015 at 03:16:27PM +0100, Richard W.M. Jones wrote:
> > On Tue, Oct 13, 2015 at 03:50:51PM +0300, Roman Kagan wrote:
> > >  
> > > -    match drivers with
> > > -    | [] ->
> > > -       warning (f_"there are no virtio drivers available for this version of Windows (%d.%d %s %s).  virt-v2v looks for drivers in %s\n\nThe guest will be configured to use slower emulated devices.")
> > > -               inspect.i_major_version inspect.i_minor_version
> > > -               inspect.i_arch inspect.i_product_variant
> > > -               virtio_win;
> > > -       ( IDE, RTL8139, Cirrus )
> > 
> > I believe this warning gets lost in this patch.
> > 
> > To get it back, let's make 'copy_virtio_drivers' returns a true/false
> > indication ('true' meaning that at least some drivers were copied),
> > and the caller code in 'install_virtio_drivers' should check this, and
> > either do the code above, or continue with the code below.
> 
> Is there any difference between not being able to locate some of the
> virtio drivers or all of them?

Yes - if there are no drivers located at all, it indicates some more
fundamental failure such as the user pointing to the wrong ISO.

In any case, if it were right to remove this warning, then it should
be done in a separate commit.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]