[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH 2/2] lib: Add comment and regression test for case where main process has large heap.



On Wed, Oct 14, 2015 at 05:03:28PM +0100, Richard W.M. Jones wrote:
> +  /* Make sure we're using > 1GB in the main process. */
> +  mem = calloc (2 * 1024, 1024 * 1024);
> +  assert (mem != NULL);

This won't work on 32 bit platforms, because it's unlikely we could
allocate 2 GB of contiguous memory.  So I'm proposing to keep the test
but have it skip if the calloc() call fails.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]