[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Libguestfs] [PATCH v3 09/13] v2v: drop redundant umount_all() and shutdown()



umount_all() and shutdown() are performed by guestfs automatically on
close(), so drop explicit calls to them right before close().

Also umount_all() in the middle of processing doesn't look justified so
drop it, too.
(The only step following it is do_fstrim() which does mounting/umounting
on its own).

Signed-off-by: Roman Kagan <rkagan virtuozzo com>
---
 v2v/v2v.ml | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/v2v/v2v.ml b/v2v/v2v.ml
index cc36422..c28905d 100644
--- a/v2v/v2v.ml
+++ b/v2v/v2v.ml
@@ -87,8 +87,6 @@ let rec main () =
   let keep_serial_console = output#keep_serial_console in
   let guestcaps = do_convert g inspect source keep_serial_console in
 
-  g#umount_all ();
-
   if no_trim <> ["*"] && (do_copy || debug_overlays) then (
     (* Doing fstrim on all the filesystems reduces the transfer size
      * because unused blocks are marked in the overlay and thus do
@@ -99,8 +97,6 @@ let rec main () =
   );
 
   message (f_"Closing the overlay");
-  g#umount_all ();
-  g#shutdown ();
   g#close ();
 
   let target_firmware = get_target_firmware inspect guestcaps source output in
-- 
2.4.3


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]