[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH v3 11/13] v2v: add --in-place mode



On Tue, Oct 20, 2015 at 04:02:39PM +0100, Richard W.M. Jones wrote:
> Can you repost the final 3 patches, rebased on top of current master?

Sure.

> On Tue, Oct 20, 2015 at 04:08:19PM +0300, Roman Kagan wrote:
> > -  let keep_serial_console = output#keep_serial_console in
> > +  let keep_serial_console = (match conversion_mode with
> > +                             | Copying (_, _) -> output#keep_serial_console
> > +                             | In_place -> true
> > +                            ) in
> 
> I don't think this change is correct.  I think you should call
> #keep_serial_console in both cases, since this is controlled by the
> guest type, not the conversion mode.

Indeed.  Thanks!

> > +and populate_disks (g:G.guestfs) src_disks =
> 
> As far as I know, the type annotation here should not be necessary.

It isn't indeed.  In my previous submission when defined with 'let' it
triggered type mismatch error without annotation; now with 'and' it no
longer does.  So yes I'll drop it.

I'll take your comments into account and resubmit.

Thanks,
Roman.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]