[Libguestfs] [PATCH 2/2] actions: turn some params into RelativePathnameList (RHBZ#1174551).

Richard W.M. Jones rjones at redhat.com
Tue Oct 20 17:57:49 UTC 2015


On Tue, Oct 20, 2015 at 01:59:10PM +0200, Pino Toscano wrote:
> diff --git a/tests/bigdirs/test-big-dirs.pl b/tests/bigdirs/test-big-dirs.pl
> index 40038b7..5bcc71c 100755
> --- a/tests/bigdirs/test-big-dirs.pl
> +++ b/tests/bigdirs/test-big-dirs.pl
> @@ -63,7 +63,6 @@ for (my $i = 0; $i < $nr_files; ++$i) {
>  # Check that lstatlist, lxattrlist and readlinklist return the
>  # expected number of entries.
>  my @a;
> - at filenames = map { "/dir/$_" } @filenames;

Yup, I'm sure that line was completely bogus, so tightening up
validation of the *list parameters would be a good thing.

Rich.

>  @a = $g->lstatlist ("/dir", \@filenames);
>  die unless @a == $nr_files;
> -- 
> 2.1.0
> 
> _______________________________________________
> Libguestfs mailing list
> Libguestfs at redhat.com
> https://www.redhat.com/mailman/listinfo/libguestfs

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top




More information about the Libguestfs mailing list