[Libguestfs] [PATCH] v2v: use open_guestfs everywhere

Pino Toscano ptoscano at redhat.com
Thu Oct 22 08:17:33 UTC 2015


On Wednesday 21 October 2015 19:31:41 Richard W.M. Jones wrote:
> On Wed, Oct 21, 2015 at 03:53:33PM +0200, Pino Toscano wrote:
> > Use the common open_guestfs to open Guestfs handles, so we get
> > debugging, tracing, and other common options set.
> > ---
> >  v2v/convert_windows.ml     | 4 +---
> >  v2v/input_disk.ml          | 2 +-
> >  v2v/input_libvirt_other.ml | 2 +-
> >  v2v/input_ova.ml           | 2 +-
> >  v2v/output_glance.ml       | 2 +-
> >  v2v/output_null.ml         | 2 +-
> >  v2v/output_rhev.ml         | 2 +-
> >  v2v/output_vdsm.ml         | 2 +-
> >  v2v/types.ml               | 2 +-
> >  v2v/v2v.ml                 | 4 ++--
> >  10 files changed, 11 insertions(+), 13 deletions(-)
> 
> I guess it sets the network flag unnecessarily, but that
> doesn't matter much so ACK.

Hm no, it doesn't, network is still explicitly enabled on the "main"
handle.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20151022/13e83957/attachment.sig>


More information about the Libguestfs mailing list