[Libguestfs] [PATCH v2 1/2] builder: add opensuse images sources

[Pino Toscano]

On Tuesday 29 September 2015 17:47:31 Richard W.M. Jones wrote:
> On Tue, Sep 29, 2015 at 03:59:34PM +0200, Cédric Bosdonnat wrote:
> > ---
> >  builder/Makefile.am      |  3 ++-
> >  builder/opensuse.conf.in |  3 +++
> >  builder/opensuse.gpg     | 21 +++++++++++++++++++++
> >  configure.ac             |  1 +
> >  4 files changed, 27 insertions(+), 1 deletion(-)
> >  create mode 100644 builder/opensuse.conf.in
> >  create mode 100644 builder/opensuse.gpg
> > 
> > diff --git a/builder/Makefile.am b/builder/Makefile.am
> > index 4bed54c..e8f8dfb 100644
> > --- a/builder/Makefile.am
> > +++ b/builder/Makefile.am
> > @@ -315,7 +315,8 @@ DISTCLEANFILES = .depend
> >  # virt-builder's default repository
> >  
> >  repoconfdir = $(sysconfdir)/xdg/virt-builder/repos.d
> > -repoconf_DATA = libguestfs.conf libguestfs.gpg
> > +repoconf_DATA = libguestfs.conf libguestfs.gpg \
> > +				opensuse.conf opensuse.gpg
> 
> Wondering if you need to add these files to EXTRA_DIST?  Some automake
> rules do this implicitly, not sure if *_DATA is one of them.

They are installed, so automake should already pack them in the
distribution tarball.

> 
> >  install-exec-hook:
> >  	$(LN_S) xdg/virt-builder $(DESTDIR)$(sysconfdir)/virt-builder
> > diff --git a/builder/opensuse.conf.in b/builder/opensuse.conf.in
> > new file mode 100644
> > index 0000000..80db267
> > --- /dev/null
> > +++ b/builder/opensuse.conf.in
> > @@ -0,0 +1,3 @@
> > +[opensuse.org]
> > +uri=http://download.opensuse.org/repositories/Virtualization:/virt-builder-images/images/index
> > +gpgkey=file://@SYSCONFDIR@/xdg/virt-builder/repos.d/opensuse.gpg
> > diff --git a/builder/opensuse.gpg b/builder/opensuse.gpg
> > new file mode 100644
> > index 0000000..001376f
> > --- /dev/null
> > +++ b/builder/opensuse.gpg
> > @@ -0,0 +1,21 @@
> > +-----BEGIN PGP PUBLIC KEY BLOCK-----
> > +Version: GnuPG v1.4.5 (GNU/Linux)
> > +
> > +mQENBFImAl0BCACkjaXGvVLHBGTVXVP0khtpUVHqFvCRtaIIMHaX/5oTr3nyehDQ
> > +Ex9VLsSRcNa0QxtnCHFRQzjWWqe+i6pBginnSjucgmjnIKyJsF4l6R+rwAiinHQX
> > +C4s6Lqg/wH9xDPRBrMYFqlc/7MVf0Glhk1+lAxgQjolMt+5AbbrWlBbwc/i+++zl
> > +ES3MaeH8aiwup/ogjhmk0SbCQQ/ib21p3XWBwx2oz/KM6Voq9tKDvMczjzNRY3ZT
> > +6Di3FsUSKI7kgljiNiuN+675YwqEqxWEJgdE5a7Zb67giH1Ik08b5wQiF5jSAICD
> > +DxW7/ibWBvZJnqhqQT2xJpLC5VaJqwkN8o83ABEBAAG0PlZpcnR1YWxpemF0aW9u
> > +IE9CUyBQcm9qZWN0IDxWaXJ0dWFsaXphdGlvbkBidWlsZC5vcGVuc3VzZS5vcmc+
> > +iQE7BBMBAgAmBQJSJgJdAhsDBQkEHrAABgsJCAcDAgQVAggDBBYCAwECHgECF4AA
> > +CgkQoZP7tXIXT8ITnwf3SVUUoVjVLFCjhIxdet8BL011cJDwr9TwKEQfq4Ybsq5L
> > +5Y1/Zk86rTzrVOZrODLwNRIC3fMuegZV5f85KMggXu37Di+UvX+dQW9v1hte+hAT
> > ++gsqb60kOnE/Yacgkb6D3xIzRudAB2q/xfvHl/hgfn416yGI8NvntT7n4Hk9wT28
> > +9JSFkun0uaessg77aXlAdsqHwdugm9hELeva89OoYoiZ4d9r4ScTMSj0UkNgnh7g
> > +CyIScZHYqiiOeosUtAX9u1PyUFfFsg9s5snfud7aF48EfXU0RTtZAGKtG4GPDv3q
> > +bYc5TJ2pQzs9y5Bk/jAMR/QQw8CKglBsn1cjYkKViEYEExECAAYFAlImAl0ACgkQ
> > +OzARt2udZSO5yACgr6Ei7QZ+PAmg4Mr5db+4M3aepAEAniU33RaTKBCGkwQi6kHr
> > +4VaII2/E
> > +=l8DH
> > +-----END PGP PUBLIC KEY BLOCK-----
> > diff --git a/configure.ac b/configure.ac
> > index 86ed4a4..98a39c1 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -1734,6 +1734,7 @@ AC_CONFIG_FILES([Makefile
> >                   bash/Makefile
> >                   builder/Makefile
> >                   builder/libguestfs.conf
> > +                 builder/opensuse.conf
> >                   builder/test-config/virt-builder/repos.d/test-index.conf
> >                   builder/test-simplestreams/virt-builder/repos.d/cirros.conf
> >                   builder/test-website/virt-builder/repos.d/libguestfs.conf
> 
> ACK.

LGTM as well, I will apply and push.

Thanks,
-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20150930/2c8af3d2/attachment.sig>