[Libguestfs] [PATCH 1/2] ocaml: Only build the tests when running 'make check'.

Pino Toscano ptoscano at redhat.com
Wed Sep 30 12:18:55 UTC 2015


On Tuesday 29 September 2015 22:45:59 Richard W.M. Jones wrote:
> Make the tests 'check_DATA' so they only get built when running the
> tests.  This saves a couple of seconds on the build time.
> ---
>  ocaml/Makefile.am | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/ocaml/Makefile.am b/ocaml/Makefile.am
> index e781363..a535b43 100644
> --- a/ocaml/Makefile.am
> +++ b/ocaml/Makefile.am
> @@ -142,9 +142,9 @@ endif
>  
>  TESTS = run-bindtests $(test_progs_all)
>  
> -noinst_DATA += bindtests.bc $(test_progs_all)
> +check_DATA = bindtests.bc $(test_progs_all)
>  if HAVE_OCAMLOPT
> -noinst_DATA += bindtests.opt
> +check_DATA += bindtests.opt
>  endif
>  
>  %.bc: %.cmo mlguestfs.cma
> @@ -204,6 +204,6 @@ install-data-hook:
>  	rm $(DESTDIR)$(OCAMLLIB)/guestfs/bindtests.*
>  	rm $(DESTDIR)$(OCAMLLIB)/guestfs/libguestfsocaml.a
>  
> -CLEANFILES += $(noinst_DATA)
> +CLEANFILES += $(noinst_DATA) $(check_DATA)
>  
>  endif

Both patches in this series LGTM.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20150930/a1697112/attachment.sig>


More information about the Libguestfs mailing list