[Libguestfs] [PATCH 1/4] lib: actions: Remove some unused header files.

Richard W.M. Jones rjones at redhat.com
Wed Sep 30 12:32:32 UTC 2015


On Wed, Sep 30, 2015 at 02:11:19PM +0200, Pino Toscano wrote:
> On Tuesday 29 September 2015 22:06:10 Richard W.M. Jones wrote:
> > ---
> >  generator/c.ml | 2 --
> >  1 file changed, 2 deletions(-)
> > 
> > diff --git a/generator/c.ml b/generator/c.ml
> > index 055b683..963cf21 100644
> > --- a/generator/c.ml
> > +++ b/generator/c.ml
> > @@ -1213,9 +1213,7 @@ and generate_client_actions hash () =
> >  #include <stdlib.h>
> >  #include <stdint.h>
> >  #include <inttypes.h>
> > -#include <sys/types.h>
> >  #include <sys/stat.h>
> > -#include <string.h>
> 
> See 78b27cc0b64a3e7b72602fc05102968b34fe529d about this.
> At least memset is used all around in the actions-N.c generated by this
> function, so IMHO string.h is justified here (apparently something
> pulls it implicitly on Linux with GNU libc, but not so on other libc's).

OK, I'm just going to drop this patch.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v




More information about the Libguestfs mailing list