[Libguestfs] [PATCH 4/4] lib: Remove unused header files.

Pino Toscano ptoscano at redhat.com
Wed Sep 30 12:05:59 UTC 2015


On Tuesday 29 September 2015 22:06:13 Richard W.M. Jones wrote:
> I used ESR's deheader program to look for unused includes.  I then
> examined each instance by hand, and also test-compiled (on Linux).

Mostly LGTM, there just a couple of notes below:

> --- a/src/fuse.c
> +++ b/src/fuse.c
> @@ -21,7 +21,6 @@
>  #include <stdio.h>
>  #include <stdlib.h>
>  #include <unistd.h>
> -#include <errno.h>

EINVAL is used here.

> --- a/src/launch-direct.c
> +++ b/src/launch-direct.c
> @@ -31,8 +30,6 @@
>  #include <sys/stat.h>
>  #include <signal.h>
>  #include <sys/socket.h>
> -#include <sys/un.h>

Isn't this needed by sockaddr_un?

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20150930/a9def8c0/attachment.sig>


More information about the Libguestfs mailing list