[Libguestfs] [PATCH 3/7] customize: add support for pvvxsvc

Richard W.M. Jones rjones at redhat.com
Tue Apr 5 12:11:22 UTC 2016


On Tue, Apr 05, 2016 at 01:47:29PM +0200, Cédric Bosdonnat wrote:
>  The output of the first boot scripts is available in the guest as
> -F<C:\Program Files\Red Hat\Firstboot\log.txt>.
> +F<C:\Program Files\Guestfs\Firstboot\log.txt>.

Changing this path is fine, but let's split it into a separate patch.

> +    let services = ["rhsrvany.exe"; "pvvxsvc.exe"] in
> +    let srvany = (
> +      try
> +        List.find (
> +          fun service -> (
> +            try
> +              let chan = open_in (virt_tools_data_dir // service) in
> +              close_in chan;
> +              true
> +            with _ ->
> +              false
> +          )
> +        ) services
> +      with Not_found ->
> +       error (f_"One of rhsrvany.exe or pvvxsvc.exe is missing in %s.  One of them is required in order to install Windows firstboot scripts.  You can get one by building rhsrvany (https://github.com/rwmjones/rhsrvany)")
> +         virt_tools_data_dir
> +    ) in (

There's a stray ( here, and lots of code gets reindented
for reasons I don't understand but may be connected to that
stray (.

> +      g#hivex_commit None;
> +      g#hivex_close ();
> +
> +      firstboot_dir
> +    )

End of the stray ) and reformatting.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v




More information about the Libguestfs mailing list