[Libguestfs] [PATCH] v2v: do not hide the error, rather report it

Tomáš Golembiovský tgolembi at redhat.com
Fri Aug 5 09:32:27 UTC 2016


The Invalid_argument exception is there to catch unexpected situation
when rpm returns no output. Such situation should be reported rather
then hidden.

Signed-off-by: Tomáš Golembiovský <tgolembi at redhat.com>
---
 v2v/linux.ml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/v2v/linux.ml b/v2v/linux.ml
index e57dad6..46cb3ba 100644
--- a/v2v/linux.ml
+++ b/v2v/linux.ml
@@ -109,8 +109,8 @@ let rec file_owner (g : G.guestfs) inspect path =
            raise Not_found
          else
            raise exn
-       | Invalid_argument msg ->
-         raise Not_found
+       | Invalid_argument "index out of bounds" ->
+         error (f_"internal error: file_owner: rpm command returned no output")
       )
 
   | format ->
-- 
2.9.2





More information about the Libguestfs mailing list