[Libguestfs] [PATCH v2 4/4] main.mk: remove sc_program_name

Pino Toscano ptoscano at redhat.com
Thu Aug 18 13:10:17 UTC 2016


There is no more need to use set_program_name in tools (getprogname
is enough for most of the cases).
* cfg.mk (local-checks-to-skip): Remove sc_program_name.
* top/maint.mk (sc_program_name): Remove.
---
 ChangeLog    | 6 ++++++
 cfg.mk       | 1 -
 top/maint.mk | 9 ---------
 3 files changed, 6 insertions(+), 10 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 7946ece..66a5101 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,11 @@
 2016-08-18  Pino Toscano  <ptoscano at redhat.com>
 
+	main.mk: remove sc_program_name, since there is no more need to
+	use set_program_name in tools (getprogname is enough for most
+	of the cases).
+	* cfg.mk (local-checks-to-skip): Remove sc_program_name.
+	* top/maint.mk (sc_program_name): Remove.
+
 	Port tests away from progname, since modules which need the
 	program name are using getprogname.
 	* modules/acl-tests (Depends-on): Remove progname.
diff --git a/cfg.mk b/cfg.mk
index 5b9456b..75d9329 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -27,7 +27,6 @@ local-checks-to-skip =			\
   sc_makefile_at_at_check		\
   sc_makefile_path_separator_check	\
   sc_obsolete_symbols			\
-  sc_program_name			\
   sc_prohibit_HAVE_MBRTOWC		\
   sc_prohibit_S_IS_definition		\
   sc_prohibit_always_true_header_tests	\
diff --git a/top/maint.mk b/top/maint.mk
index 868e10f..c32f8b6 100644
--- a/top/maint.mk
+++ b/top/maint.mk
@@ -717,15 +717,6 @@ sc_changelog:
 	  $(_sc_search_regexp)
 
 # Ensure that each .c file containing a "main" function also
-# calls set_program_name.
-sc_program_name:
-	@require='set_program_name *\(.*\);'				\
-	in_vc_files='\.c$$'						\
-	containing='\<main *('						\
-	halt='the above files do not call set_program_name'		\
-	  $(_sc_search_regexp)
-
-# Ensure that each .c file containing a "main" function also
 # calls bindtextdomain.
 sc_bindtextdomain:
 	@require='bindtextdomain *\('					\
-- 
2.7.4




More information about the Libguestfs mailing list