[Libguestfs] [PATCH] v2v: do not hide the error, rather report it

[Pino Toscano]

On Friday, 5 August 2016 12:25:03 CEST Richard W.M. Jones wrote:
> On Fri, Aug 05, 2016 at 11:32:27AM +0200, Tomáš Golembiovský wrote:
> > The Invalid_argument exception is there to catch unexpected situation
> > when rpm returns no output. Such situation should be reported rather
> > then hidden.
> > 
> > Signed-off-by: Tomáš Golembiovský <tgolembi at redhat.com>
> > ---
> >  v2v/linux.ml | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/v2v/linux.ml b/v2v/linux.ml
> > index e57dad6..46cb3ba 100644
> > --- a/v2v/linux.ml
> > +++ b/v2v/linux.ml
> > @@ -109,8 +109,8 @@ let rec file_owner (g : G.guestfs) inspect path =
> >             raise Not_found
> >           else
> >             raise exn
> > -       | Invalid_argument msg ->
> > -         raise Not_found
> > +       | Invalid_argument "index out of bounds" ->
> > +         error (f_"internal error: file_owner: rpm command returned no output")
> >        )
> 
> Unlike Pino I'm actually OK with this fix.  It's up to you if
> you want to try it Pino's way.

OK, pushed this as is then.

Thanks,
-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20160808/35da2520/attachment.sig>