[Libguestfs] [PATCH v2] v2v: linux: accept 'sr' devices in fstab

Pino Toscano ptoscano at redhat.com
Thu Aug 11 10:48:48 UTC 2016


On Thursday, 11 August 2016 09:02:29 CEST Richard W.M. Jones wrote:
> From: Tomáš Golembiovský <tgolembi at redhat.com>
> 
> Do not print warning for 'sr' devices when converting fstab. Not all
> systems create the /dev/cdrom symlink for SCSI CD-ROM devices. Moreover,
> on systems with multiple CD-ROMs, having entries for /dev/sr* devices
> may be inevitable.
> 
> RWMJ: Use String.is_prefix instead of String.find, to more accurately
> match on the device name.
> 
> Signed-off-by: Tomáš Golembiovský <tgolembi at redhat.com>
> Signed-off-by: Richard W.M. Jones <rjones at redhat.com>
> ---

LGTM.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20160811/bb3444bd/attachment.sig>


More information about the Libguestfs mailing list