[Libguestfs] [PATCH v2 2/6] daemon: refactor tsk code
Pino Toscano
ptoscano at redhat.com
Fri Aug 26 11:27:33 UTC 2016
On Thursday, 25 August 2016 23:53:52 CEST Matteo Cafasso wrote:
> Refactor logic in preparation for new APIs.
>
> Signed-off-by: Matteo Cafasso <noxdafox at gmail.com>
> ---
Mostly LGTM, just a couple of minor notes.
> +static int
> +send_dirent_info(TSK_FS_FILE *fsfile, const char *path)
Nitpick wrt coding style.
> + /* Extract dirent information. */
> + memset (&dirent, 0, sizeof dirent);
I guess the comment that was below fits better:
/* Set dirent fields */
Thanks,
--
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20160826/7be6c42e/attachment.sig>
More information about the Libguestfs
mailing list