[Libguestfs] [PATCH v2 4/6] New API: internal_find_inode

[Pino Toscano]

On Thursday, 25 August 2016 23:53:54 CEST Matteo Cafasso wrote:
> The internal_find_inode command searches all entries referring to the
> given inode and returns a tsk_dirent structure for each of them.
> 
> The command is able to retrieve information regarding deleted
> or unaccessible files where other commands such as stat or find
> would fail.
> 
> The gathered list of tsk_dirent structs is serialised into XDR format
> and written to a file by the appliance.
> 
> Signed-off-by: Matteo Cafasso <noxdafox at gmail.com>
> ---

Mostly LGTM, just a couple of notes.

> +
> +  if (entry_is_dot(fsfile))

Coding style nitpick.

> +  { defaults with
> +    name = "internal_find_inode"; added = (1, 35, 2);
> +    style = RErr, [Mountable "device"; Int64 "inode"; FileOut "filename";], [];
> +    proc_nr = Some 469;

This now needs to be 470.

Thanks,
-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20160826/50ec640b/attachment.sig>