[Libguestfs] [PATCH 0/3] Miscellaneous improvements to supermin.

Pino Toscano ptoscano at redhat.com
Wed Dec 7 15:01:50 UTC 2016


On Wednesday, 7 December 2016 14:04:43 CET Richard W.M. Jones wrote:
> Document what each module does, using *.mli files.
> 
> Remove the --dtb option, it's obsolete.
> 
> Rename modules according to their purpose.

Generally LGTM.

The only note is about the removal of --dtb: wouldn't it better to
leave a stub option? It would explicitly print out it was removed,
so when specified it's clearer it was not a typo but intentional
functionality drop/change.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20161207/8a7c5a0c/attachment.sig>


More information about the Libguestfs mailing list