[Libguestfs] increasing HIVEX_MAX_SUBKEYS and HIVEX_MAX_VALUES

Matt Coleman mcoleman at datto.com
Sat Dec 3 20:41:22 UTC 2016


> Do you have the alternate patch that just increases the limits to 1.5x what you need?
I've attached an updated patch that increases the limits based on the counts observed in the Microsoft\Windows NT\CurrentVersion subkey of the software hive.

> We're building a list of (up to) HIVEX_MAX_SUBKEYS * 4 bytes (not counting intermediate blocks) in the _get_children function.  While it's not a massive amount of memory in a modern system, I think if we're going to increase them substantially we should make these limits configurable which makes everyone happy.

Sounds good. I'll start looking at making it configurable.

Matt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Increase-HIVEX_MAX_SUBKEYS-and-HIVEX_MAX_VALUES.patch
Type: application/octet-stream
Size: 1011 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20161203/0dad6ebf/attachment.obj>


More information about the Libguestfs mailing list