[Libguestfs] [PATCH 0/5] Improve inspection of /usr filesystems

[Richard W.M. Jones]

On Tue, Dec 06, 2016 at 04:29:17PM +0100, Pino Toscano wrote:
> Hi,
> 
> this patch series improves the way /usr filesystems are handled: tag
> them appropriately, so later on we can find them and merge results they
> contain directly back for the root filesystem.
> 
> The series includes also a new private debug API, and its usage to fix
> the resolution of /dev/mapper/.. devices found in fstab; without it,
> LVM /usr filesystems are not recognized as belonging to their roots.
> Maybe a better API for this could be added, but since it's something
> only related to the appliance then can stay internal for now. (Better
> suggestions always welcome, of course.)

Firstly, I still think we need:

  [PATCH 1/2] inspect: fstab: Canonicalize paths appearing in fstab.

although it's not related to the current patch series.

In regards to this series:

> Pino Toscano (5):
>   inspect: change is_root flag into enum
>   inspect: mark CoreOS /usr partitions with own USR role

These are fine.

>   daemon: debug: new "exists" subcommand
>   inspect: fix existance check of /dev/mapper devices

This is very ugly.  We really shouldn't be calling a debug API from
inspection code.

>   inspect: gather info from /usr filesystems as well (RHBZ#1401474)

I have specific comments on this patch.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.
http://libguestfs.org/virt-v2v