[Libguestfs] [PATCH 0/5] Improve inspection of /usr filesystems

[Richard W.M. Jones]

On Wed, Dec 07, 2016 at 10:49:44AM +0100, Pino Toscano wrote:
> On Wednesday, 7 December 2016 08:29:54 CET Richard W.M. Jones wrote:
> > On Tue, Dec 06, 2016 at 04:29:17PM +0100, Pino Toscano wrote:
> > > Hi,
> > > 
> > > this patch series improves the way /usr filesystems are handled: tag
> > > them appropriately, so later on we can find them and merge results they
> > > contain directly back for the root filesystem.
> > > 
> > > The series includes also a new private debug API, and its usage to fix
> > > the resolution of /dev/mapper/.. devices found in fstab; without it,
> > > LVM /usr filesystems are not recognized as belonging to their roots.
> > > Maybe a better API for this could be added, but since it's something
> > > only related to the appliance then can stay internal for now. (Better
> > > suggestions always welcome, of course.)
> > 
> > Firstly, I still think we need:
> > 
> >   [PATCH 1/2] inspect: fstab: Canonicalize paths appearing in fstab.
> > 
> > although it's not related to the current patch series.
> 
> This was not an issue in the data of RHBZ#140147, do you have an example
> of guest with such paths in fstab? So far I never seen one myself.

I don't, but it could happen and I see no problem with canonicalizing
these paths.  Having these "weird" paths in fstab causes the same
paths to be returned by guestfs_inspect_get_filesystems and might
cause problems for other API users.

> > >   daemon: debug: new "exists" subcommand
> > >   inspect: fix existance check of /dev/mapper devices
> > 
> > This is very ugly.  We really shouldn't be calling a debug API from
> > inspection code.
> 
> As mentioned above, any better suggestion is welcome. I didn't want to
> add a new public API for inspecting files in the appliance itself --
> what about something like internal_exists?

I'll follow up on the commit message.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/