[Libguestfs] [PATCH 0/3] Miscellaneous improvements to supermin.

Richard W.M. Jones rjones at redhat.com
Wed Dec 7 15:04:57 UTC 2016


On Wed, Dec 07, 2016 at 04:01:50PM +0100, Pino Toscano wrote:
> On Wednesday, 7 December 2016 14:04:43 CET Richard W.M. Jones wrote:
> > Document what each module does, using *.mli files.
> > 
> > Remove the --dtb option, it's obsolete.
> > 
> > Rename modules according to their purpose.
> 
> Generally LGTM.
> 
> The only note is about the removal of --dtb: wouldn't it better to
> leave a stub option? It would explicitly print out it was removed,
> so when specified it's clearer it was not a typo but intentional
> functionality drop/change.

OK I'll modify this and then push.

Thanks,

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top




More information about the Libguestfs mailing list