[Libguestfs] [PATCH v2 5/5] v2v: update tests to match changes in OVA import

Pino Toscano ptoscano at redhat.com
Wed Dec 7 15:21:19 UTC 2016


On Tuesday, 6 December 2016 15:40:33 CET Tomas Golembiovsky wrote:
> On Wed, Nov 30, 2016 at 4:44 PM, Pino Toscano <ptoscano at redhat.com> wrote:
> 
> > On Wednesday, 23 November 2016 16:40:59 CET Tomáš Golembiovský wrote:
> > > On Mon, 21 Nov 2016 16:41:49 +0100
> > > Pino Toscano <ptoscano at redhat.com> wrote:
> > > > On Saturday, 12 November 2016 16:37:53 CET Tomáš Golembiovský wrote:
> > > > >  v2v/Makefile.am                         |   1 +
> > > > >  v2v/test-v2v-i-ova-formats.sh           |   5 +-
> > > > >  v2v/test-v2v-i-ova-subfolders.expected2 |  18 +++++
> > > > >  v2v/test-v2v-i-ova-subfolders.sh        |  12 ++-
> > > > >  v2v/test-v2v-i-ova-tar.expected         |  18 +++++
> > > > >  v2v/test-v2v-i-ova-tar.expected2        |  18 +++++
> > > > >  v2v/test-v2v-i-ova-tar.ovf              | 138
> > ++++++++++++++++++++++++++++++++
> > > >
> > > > The ovf and expected files are basically copies of the -formats
> > > > versions -- would it be possible to reuse them?
> > >
> > > Wouldn't that be confusing?
> > >
> > > Maybe I could rename it to test-v2v-i-ova.ovf and
> > > test-v2v-i-ova.expected and then use it in both tests.
> >
> > Good idea.
> >
> >
> It turned out that there already is "test-v2v-i-ova.ovf" so renaming is not
> possible. Any other ideas?

Let's drop this idea for now. Sorry for the extra time.

Thanks,
-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20161207/0c57a9e9/attachment.sig>


More information about the Libguestfs mailing list