[Libguestfs] [PATCH v3 4/6] mllib: modify nsplit to take optional noempty and count arguments

Pino Toscano ptoscano at redhat.com
Fri Dec 9 09:52:23 UTC 2016


On Wednesday, 7 December 2016 17:13:08 CET Tomáš Golembiovský wrote:
> Added two new optional arguments to nsplit:
> 
> * noempty: if set to false empty elements are not stored in the returned
>   list. The default is to keep the empty elements
> 
> * count: specifies how many splits to perform; negative count
>   (the default) means do as many splits as possible
> 
> Signed-off-by: Tomáš Golembiovský <tgolembi at redhat.com>
> ---

LGTM -- while you are here, what about adding tests for it in
mllib/common_utils_tests.ml?

Thanks,
-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20161209/c8c5c80e/attachment.sig>


More information about the Libguestfs mailing list