[Libguestfs] [PATCH v3 4/6] mllib: modify nsplit to take optional noempty and count arguments

Tomas Golembiovsky tgolembi at redhat.com
Sat Dec 10 12:52:52 UTC 2016


On Fri, 9 Dec 2016 12:49:04 +0000
"Richard W.M. Jones" <rjones at redhat.com> wrote:

> On Fri, Dec 09, 2016 at 10:52:23AM +0100, Pino Toscano wrote:
> > On Wednesday, 7 December 2016 17:13:08 CET Tomáš Golembiovský wrote:
> > > Added two new optional arguments to nsplit:
> > >
> > > * noempty: if set to false empty elements are not stored in the returned
> > >   list. The default is to keep the empty elements
> > >
> > > * count: specifies how many splits to perform; negative count
> > >   (the default) means do as many splits as possible
> > >
> > > Signed-off-by: Tomáš Golembiovský <tgolembi at redhat.com>
> > > ---
> >
> > LGTM -- while you are here, what about adding tests for it in
> > mllib/common_utils_tests.ml?
>
> It definitely needs tests.

Sure, I will add some.

        Tomas
-- 
Tomáš Golembiovský <tgolembi at redhat.com>




More information about the Libguestfs mailing list