[Libguestfs] [PATCH] daemon: expose file upload logic

Richard W.M. Jones rjones at redhat.com
Thu Dec 15 08:59:45 UTC 2016


On Thu, Dec 15, 2016 at 12:12:12AM +0200, Matteo Cafasso wrote:
> +int
> +upload_to_fd (int fd)
> +{
> +  int ret = 0, err = 0;

Don't initialize these variables (they were not initialized in the
previous code).  It stops GCC from noticing if you've used the
variables uninitialized later.

I'm going to wait on this patch to see how the upload_to_fd function
is used in later patches.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top




More information about the Libguestfs mailing list