[Libguestfs] [PATCH 1/2] launch: Rationalize how we construct the Linux kernel command line.

[Pino Toscano]

On Sunday, 18 December 2016 20:09:28 CET Richard W.M. Jones wrote:
> This is just code refactoring.
> ---

Mostly LGTM, just one note.

> +  return guestfs_int_join_strings (" ", argv.argv);

Currently, safe_asprintf aborts on ENOMEM errors, while
guestfs_int_join_strings just returns NULL on that situation -- most
probably the abort callback needs to be invoked manually:

  char *ret;
  ...
  ret = guestfs_int_join_strings (" ", argv.argv);
  if (ret == NULL)
    g->abort_cb ();

  return ret;

Thanks,
-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20161222/22d826e1/attachment.sig>