[Libguestfs] [PATCH] java: drop empty lines at end of pod-generated text

Pino Toscano ptoscano at redhat.com
Fri Feb 26 17:01:59 UTC 2016


They are converted as additional empty paragraphs but adding nothing to
the generated API documentation.  Also avoids warnings about them by
javadoc.
---
 generator/java.ml | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/generator/java.ml b/generator/java.ml
index 4821b34..2a41a5f 100644
--- a/generator/java.ml
+++ b/generator/java.ml
@@ -32,6 +32,13 @@ open C
 
 let generate_header = generate_header ~inputs:["generator/java.ml"]
 
+let drop_empty_trailing_lines l =
+  let rec loop = function
+    | "" :: tl -> loop tl
+    | x -> x
+  in
+  List.rev (loop (List.rev l))
+
 (* Generate Java bindings GuestFS.java file. *)
 let rec generate_java_java () =
   generate_header CStyle LGPLv2plus;
@@ -262,6 +269,7 @@ public class GuestFS {
             doc ^ "\n\n" ^ protocol_limit_warning
           else doc in
         let doc = pod2text ~width:60 f.name doc in
+        let doc = drop_empty_trailing_lines doc in
         let doc = List.map (		(* RHBZ#501883 *)
           function
           | "" -> "</p><p>"
-- 
2.5.0




More information about the Libguestfs mailing list