[Libguestfs] [PATCH 1/8] run.in: Remove out of date documentation for using $(VG).

Richard W.M. Jones rjones at redhat.com
Mon Feb 22 13:59:12 UTC 2016


Since we enabled parallel tests, you can no longer run tests
under valgrind merely by doing:

  TESTS_ENVIRONMENT = $(top_builddir)/run --test $(VG)
  check-valgrind:
      $(MAKE) check VG="@VG@"

The reason is that the parallel tests framework doesn't run
``$(TESTS_ENVIRONMENT) <test>''.  It inserts some other processes in
between the environment and the test, so you end up valgrinding some
unrelated process (currently ``env'').
---
 run.in | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/run.in b/run.in
index ed4109c..c911834 100755
--- a/run.in
+++ b/run.in
@@ -33,13 +33,10 @@
 #
 # The script should also be used for tests like this:
 #
-#   TESTS_ENVIRONMENT = ... $(top_builddir)/run --test [$(VG)]
+#   TESTS_ENVIRONMENT = ... $(top_builddir)/run --test
 #
 # The --test parameter introduces a timeout, stopping tests from
 # running forever.
-#
-# Use the optional $(VG) when the tests must also be run under
-# valgrind.
 
 #----------------------------------------------------------------------
 
-- 
2.5.0




More information about the Libguestfs mailing list