[Libguestfs] [PATCH v2 4/4] v2v: in-place: request caps based on source config

[Richard W.M. Jones]

On Wed, Feb 24, 2016 at 05:33:44PM +0300, Roman Kagan wrote:
> Passing that on the command line makes sense for the copying mode,
> because in that mode there's no other place where to affect the choices.
> 
> In the in-place mode virt-v2v is given a VM with the configuration
> already converted and the choices made (with or without user
> interaction); v2v is only expected to tune the guest to work in that
> configuration.  So in that case rcaps are based on the source (==
> target) VM properties.

I think this makes 'virt-v2v --inplace' a bit less useful as a general
thing you can do with the tool.  Can we switch on this behaviour only
if there is a command line flag?  That would ensure that 'virt-v2v
--inplace' is a generally useful feature for people who want virt-v2v
to install the best drivers, while your use case is still possible (by
passing the flag).

Alternately (and a bit more work): expose the requested guestcaps
completely through the command line, eg:

  --request-block=[virtio|ide|best]
  --request-net=[virtio|e1000|rtl8139|best]
  --request-video=[qxl|cirrus|best]

where 'best' == None (I think?)

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org