[Libguestfs] [PATCH 3/3] src: print contents of structs and struct lists on tracing

[Pino Toscano]

On Thursday 25 February 2016 13:58:28 Richard W.M. Jones wrote:
> On Thu, Feb 25, 2016 at 02:30:48PM +0100, Pino Toscano wrote:
> > On Thursday 25 February 2016 12:31:30 Richard W.M. Jones wrote:
> > > On Wed, Feb 24, 2016 at 01:52:04PM +0100, Pino Toscano wrote:
> > > > It eases the debugging, instead of getting just the name of the struct
> > > > returned.
> > > 
> > > The series is fine, so ACK.  Definitely improves the trace output :-)
> > 
> > Thanks -- I got tired of not seeing what was returned in case of
> > structs.
> > 
> > > A few things that would be good though:
> > > 
> > >  - Export the functions through the public API.  We already have
> > >    functions to copy structs (eg. guestfs_copy_application,
> > >    guestfs_copy_application_list).
> > 
> > Would be actually worth exporting them for general usage, though?
> > I thought about this, and I did not find immediate use cases; although
> > I can change idea if there are enough/good ones.
> 
> They become part of the API and ABI so we need to be really sure that
> we want to support the functions forever.  But assuming they're well
> designed and future-proof I don't see why not.

Yes, and that's why I'm hesitant to make them public for now: I've not
really designed them to be future-proof, but just as shared code
between the tracing bits and guestfish.

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20160225/231f6384/attachment.sig>