[Libguestfs] [PATCH] xfs_admin: do not set lazycounter in tests not checking that

Richard W.M. Jones rjones at redhat.com
Tue Jan 26 10:50:07 UTC 2016


On Tue, Jan 26, 2016 at 11:28:02AM +0100, Pino Toscano wrote:
> This flag cannot be disabled (yet) in V5 xfs filesystems; since 2 out
> of the current 3 tests of xfs_admin check other results than that flag,
> avoid setting it when not needed.
> ---
>  generator/actions.ml | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/generator/actions.ml b/generator/actions.ml
> index 9ea5736..14902e7 100644
> --- a/generator/actions.ml
> +++ b/generator/actions.ml
> @@ -10928,12 +10928,12 @@ with zeroes)." };
>          InitEmpty, Always, TestResultString (
>            [["part_disk"; "/dev/sda"; "mbr"];
>             ["mkfs"; "xfs"; "/dev/sda1"; ""; "NOARG"; ""; ""; "NOARG"];
> -           ["xfs_admin"; "/dev/sda1"; ""; ""; ""; ""; "false"; "NOARG"; uuid];
> +           ["xfs_admin"; "/dev/sda1"; ""; ""; ""; ""; ""; "NOARG"; uuid];
>             ["vfs_uuid"; "/dev/sda1"]], uuid), [];
>          InitEmpty, Always, TestResultString (
>            [["part_disk"; "/dev/sda"; "mbr"];
>             ["mkfs"; "xfs"; "/dev/sda1"; ""; "NOARG"; ""; ""; "NOARG"];
> -           ["xfs_admin"; "/dev/sda1"; ""; ""; ""; ""; "false"; "LBL-TEST"; "NOARG"];
> +           ["xfs_admin"; "/dev/sda1"; ""; ""; ""; ""; ""; "LBL-TEST"; "NOARG"];
>             ["vfs_label"; "/dev/sda1"]], "LBL-TEST"), [];
>        ]);
>      shortdesc = "change parameters of an XFS filesystem";

ACK.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines.  Supports shell scripting,
bindings from many languages.  http://libguestfs.org




More information about the Libguestfs mailing list