[Libguestfs] [PATCH] daemon: fold xfs_admin stdout to stderr

[Richard W.M. Jones]

On Tue, Jan 26, 2016 at 11:28:03AM +0100, Pino Toscano wrote:
> Apparent newer versions of that report everything on stdout, including
> error messages; since we only print something on failure, fold stdout to
> stderr so we can see everything on failure.
> ---
>  daemon/xfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/daemon/xfs.c b/daemon/xfs.c
> index abc2736..7f72e6a 100644
> --- a/daemon/xfs.c
> +++ b/daemon/xfs.c
> @@ -537,7 +537,7 @@ do_xfs_admin (const char *device,
>    ADD_ARG (argv, i, device);
>    ADD_ARG (argv, i, NULL);
>  
> -  r = commandv (NULL, &err, argv);
> +  r = commandvf (NULL, &err, COMMAND_FLAG_FOLD_STDOUT_ON_STDERR, argv);
>    if (r == -1) {
>      reply_with_error ("%s: %s", device, err);
>      return -1;

Grrr external tools.

ACK.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top