[Libguestfs] [PATCH] p2v: User can click on an interface name to identify the physical interface.

[Richard W.M. Jones]

On Tue, Jan 26, 2016 at 05:37:07PM +0000, Richard W.M. Jones wrote:
> On Tue, Jan 26, 2016 at 06:14:18PM +0100, Pino Toscano wrote:
> > On Tuesday 26 January 2016 15:38:07 Richard W.M. Jones wrote:
> > > When the user clicks on the second column of the list of network
> > > interfaces, run 'ethtool --identify <if_name> 10', which (on supported
> > > cards) flashes a light on the physical interface for 10 seconds,
> > > allowing it to be identified by the operator.
> > > 
> > > This has a nasty bit of hidden UI, basically because Gtk makes it near
> > > impossible to put a regular button into a GtkTreeView.
> > > ---
> > 
> > Wouldn't it better than add a simple "Identify interface" next to the
> > list? IMHO would be more explicit, and avoid spawning ethtool commands
> > when not wanted.
> 
> I think do you mean another column with a label [not a button,
> unfortunately] marked "identify interface"?  That is possible.  Also
> we could add that text to the Device column.

Adding the text "Identify interface" (underlined) makes it look like a
link.  The behaviour is still the same as you can click anywhere in
the cell.  See screenshot.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
Fedora Windows cross-compiler. Compile Windows programs, test, and
build Windows installers. Over 100 libraries supported.
http://fedoraproject.org/wiki/MinGW
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screenshot_2016-01-26_17-41-35.png
Type: image/png
Size: 28807 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20160126/712982be/attachment.png>