[Libguestfs] [PATCH] lvm: support lvm2 older than 2.02.107

[Richard W.M. Jones]

On Wed, Jan 27, 2016 at 07:06:46PM +0100, Pino Toscano wrote:
>  char **
>  do_lvs (void)
>  {
>    char *out;
>    CLEANUP_FREE char *err = NULL;
>    int r;
> +  int has_S = test_lvs_has_S_opt ();
> +  if (has_S < 0)
>      return NULL;

I think this doesn't do the right thing on the second failing call
to test_lvs_has_S_opt, because it won't return a protocol error?


> +  /*NOTREACHED*/
> +  assert (false);
> +  return NULL;
>  }

What's this bit for?  It is indeed NOTREACHED, but it seems as if
the 3 lines could just be removed.

Rest looks fine, so ACK with those fixed.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-df lists disk usage of guests without needing to install any
software inside the virtual machine.  Supports Linux and Windows.
http://people.redhat.com/~rjones/virt-df/