[Libguestfs] [PATCH 1/2] v2v: register also aliases of input/output modules

[Richard W.M. Jones]

On Mon, Jul 18, 2016 at 07:29:53PM +0200, Pino Toscano wrote:
> This makes them visible in the help text of -i and -o.
> ---
>  v2v/input_disk.ml   | 5 ++++-
>  v2v/output_local.ml | 5 ++++-
>  v2v/output_rhev.ml  | 5 ++++-
>  3 files changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/v2v/input_disk.ml b/v2v/input_disk.ml
> index 17ad61d..508f16a 100644
> --- a/v2v/input_disk.ml
> +++ b/v2v/input_disk.ml
> @@ -101,4 +101,7 @@ class input_disk input_format disk = object
>  end
>  
>  let input_disk = new input_disk
> -let () = Modules_list.register_input_module "disk"
> +let () =
> +  Modules_list.register_input_module "disk";
> +  (* Alias *)
> +  Modules_list.register_input_module "local"
> diff --git a/v2v/output_local.ml b/v2v/output_local.ml
> index 47da929..f2945ec 100644
> --- a/v2v/output_local.ml
> +++ b/v2v/output_local.ml
> @@ -61,4 +61,7 @@ class output_local dir = object
>  end
>  
>  let output_local = new output_local
> -let () = Modules_list.register_output_module "local"
> +let () =
> +  Modules_list.register_output_module "local";
> +  (* Alias *)
> +  Modules_list.register_output_module "disk"
> diff --git a/v2v/output_rhev.ml b/v2v/output_rhev.ml
> index e45043b..bec5f44 100644
> --- a/v2v/output_rhev.ml
> +++ b/v2v/output_rhev.ml
> @@ -282,4 +282,7 @@ object
>  end
>  
>  let output_rhev = new output_rhev
> -let () = Modules_list.register_output_module "rhev"
> +let () =
> +  Modules_list.register_output_module "rhev";
> +  (* Alias *)
> +  Modules_list.register_output_module "ovirt"

Technically this will alter the "Output to (-o)" combo box in virt-p2v
so it lists both the options and their aliases.  However I guess that
isn't actually a problem.

ACK.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top