[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] tests: Implement script to check documented tool options match actual options.



On Tue, Jul 19, 2016 at 10:27:30AM +0200, Pino Toscano wrote:
> On Monday, 18 July 2016 18:02:11 CEST Richard W.M. Jones wrote:
> > podcheck.pl is run as part of the tests to perform various
> > checks on the documentation and the tool.
> > 
> > Currently we check only that the documented options matches the
> > options that the tool implements and vice versa.  This commit would
> > also allow us (in future) to check --help, --long-options,
> > --short-options, --version output.
> > 
> > This commit includes scripts to run the tests and various fixes to the
> > manual pages to ensure that the tests pass.
> > ---
> 
> LGTM, just one small note:
> 
> > +delete $tool_option_exists{"--debug-gc"};
> 
> This shouldn't be needed anymore.

Turns out this is necessary because the option is still listed in
--long-options output (as it should be, because you want to be able to
autocomplete any option).

Thanks for the review, I pushed this now.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]