[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[Libguestfs] [PATCH] mllib, customize: Don't add -g option to ocamlmklib command line.



Pino alerted me to this problem -- it's quite clear if you try
to compile libguestfs from git on RHEL 7.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-top is 'top' for virtual machines.  Tiny program with many
powerful monitoring features, net stats, disk stats, logging, etc.
http://people.redhat.com/~rjones/virt-top
>From 3fea29daf3c2e529eb8341cc75ffd4f93f9e5f3e Mon Sep 17 00:00:00 2001
From: "Richard W.M. Jones" <rjones redhat com>
Date: Tue, 19 Jul 2016 21:41:07 +0100
Subject: [PATCH] mllib, customize: Don't add -g option to ocamlmklib command
 line.

ocamlmklib -g does not work in OCaml 4.01.0.  It does work (and is
desirable) in OCaml 4.02.2.  However since we would like to support
back to OCaml 3.11, we cannot use it.
---
 customize/Makefile.am | 2 +-
 mllib/Makefile.am     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/customize/Makefile.am b/customize/Makefile.am
index 0fc064b..a4d537f 100644
--- a/customize/Makefile.am
+++ b/customize/Makefile.am
@@ -131,7 +131,7 @@ endif
 libcustomize_a_DEPENDENCIES = $(OBJECTS)
 
 $(CUSTOMIZE_CMA): $(OBJECTS) libcustomize.a
-	$(OCAMLFIND) mklib -g $(OCAMLPACKAGES) \
+	$(OCAMLFIND) mklib $(OCAMLPACKAGES) \
 	    $(OBJECTS) $(libcustomize_a_OBJECTS) -o customize
 
 # Build the virt-customize program.
diff --git a/mllib/Makefile.am b/mllib/Makefile.am
index f9db099..8f8b5f4 100644
--- a/mllib/Makefile.am
+++ b/mllib/Makefile.am
@@ -143,7 +143,7 @@ endif
 libmllib_a_DEPENDENCIES = $(OBJECTS)
 
 $(MLLIB_CMA): $(OBJECTS) libmllib.a
-	$(OCAMLFIND) mklib -g $(OCAMLPACKAGES) \
+	$(OCAMLFIND) mklib $(OCAMLPACKAGES) \
 	    $(OBJECTS) $(libmllib_a_OBJECTS) -o mllib
 
 # This OCaml module has to be generated by make (configure will put
-- 
1.8.3.1


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]