[Libguestfs] [PATCH v2 0/2] Added download_blocks API
Pino Toscano
ptoscano at redhat.com
Wed Jul 20 14:04:25 UTC 2016
Hi,
On Sunday, 17 July 2016 20:40:18 CEST Matteo Cafasso wrote:
> v2:
>
> - Rebase on top of master
>
> Matteo Cafasso (2):
> New API: download_blocks
> Added download_blocks API test
>
> daemon/sleuthkit.c | 41 ++++++++++++++++++++++++++-
> generator/actions.ml | 24 ++++++++++++++++
> gobject/Makefile.inc | 2 ++
> src/MAX_PROC_NR | 2 +-
> tests/tsk/Makefile.am | 1 +
> tests/tsk/test-download-blocks.sh | 58 +++++++++++++++++++++++++++++++++++++++
> 6 files changed, 126 insertions(+), 2 deletions(-)
> create mode 100755 tests/tsk/test-download-blocks.sh
The series LGTM, I pushed it after removing the extra change in
do_download_inode and fixing the version.
More a curiosity question than a complain or something else: how are
these APIs are supposed to be used? What is the forensics-related
workflow using them? Considering they are quite specific, I was
thinking about adding a documentation paragraph and/or some example
to describe/show them better, what do you think?
Thanks,
--
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20160720/35be02a3/attachment.sig>
More information about the Libguestfs
mailing list