[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [Libguestfs] [PATCH] osinfo: revamp db reading (RHBZ#1359652)



On Mon, Jul 25, 2016 at 05:47:05PM +0200, Pino Toscano wrote:
> +  if (path == NULL)
> +    path = "/usr/share/osinfo";

I wonder if we should use $prefix here.  I guess there are
arguments both ways.

Should we just run the external osinfo-query program?

Anyway it's fine as it stands, so ACK.

Rich.

-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]