[Libguestfs] [PATCH] sysprep: Enable the network, add --no-network to disable it (RHBZ#1345813).

[Pino Toscano]

On Monday 13 June 2016 11:21:15 Richard W.M. Jones wrote:
> In commit ae6f726ecc3bc1b67fd76e51a7b1e1a33d4dcfc0 we started to use
> the virt-customize code to replace various virt-sysprep operations.
> This had the effect of adding many more possible operationg to
> virt-sysprep, but some of them (specifically --install) did not work
> unless the appliance network is enabled.  It was not enabled in
> virt-sysprep, so these operations never worked.
> 
> This change enables the network by default, so operations such as
> --install will now work.  For enhanced security it is possible to
> disable the network by adding the --no-network flag.

I'd still disable the network by default.  As you wrote, --install
and other network-using operations didn't work before, so there is
no "compatibility" with them that we need to keep -- users will need
to require network to make the command work, and using an explicit
--network will make sure the command breaks right away when used with
older virt-sysprep.

Thanks,
-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20160613/a86f94e7/attachment.sig>