[Libguestfs] [PATCH 1/2] increase the default memory size to 768 MB

[Pavel Butsykin]

On 12.06.2016 15:01, Richard W.M. Jones wrote:
> On Sat, Jun 11, 2016 at 09:35:40PM +0100, Richard W.M. Jones wrote:
>> On Sat, Jun 11, 2016 at 08:51:56PM +0300, Pavel Butsykin wrote:
>>> The appliance memory size of 500 MB is insufficient in certain scenarios.  In
>>> partiuclar, semodule (which may be called by a guest tools uninstaller) often
>>> triggers OOM (see https://bugzilla.redhat.com/426775)
>>>
>>> Increase it to 768 MB.
>>>
>>> Signed-off-by: Pavel Butsykin <pbutsykin at virtuozzo.com>
>>> ---
>>>   src/guestfs-internal.h | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/src/guestfs-internal.h b/src/guestfs-internal.h
>>> index 03f1034..1d1b996 100644
>>> --- a/src/guestfs-internal.h
>>> +++ b/src/guestfs-internal.h
>>> @@ -93,7 +93,7 @@
>>>
>>>   /* The default and minimum memory size for most users. */
>>>   #ifndef DEFAULT_MEMSIZE
>>> -#  define DEFAULT_MEMSIZE 500
>>> +#  define DEFAULT_MEMSIZE 768
>>>   #endif
>>>   #ifndef MIN_MEMSIZE
>>>   #  define MIN_MEMSIZE 128
>>
>> If only we had a more sensible way to allocate memory :-(
>>
>> Anyway, this patch needs to remove the earlier lines which set
>> DEFAULT_MEMSIZE to 768 on __powerpc__ and __aarch64__.
>
> When I thought about this a bit more, I think what you want is to just
> increase the memory limit for virt-v2v.  How about the attached?
> (Only compile tested.)

Yes, that's right, I'm just here to follow the rule - the simpler the
better :) Your solution is more correct, because it allows to go to the
next step, to make this knowledge outward. The caller may know better
need extra memory or not. For example, in the context of this issue, we
do not need additional memory for windows guests.

>
> Rich.
>