[Libguestfs] Fwd: libguestfs patch

Richard W.M. Jones rjones at redhat.com
Fri Mar 18 15:05:10 UTC 2016

----- Forwarded message from "Bernhard M. Wiedemann" <bwiedemann at suse.de> -----

Date: Fri, 18 Mar 2016 15:41:16 +0100
From: "Bernhard M. Wiedemann" <bwiedemann at suse.de>
To: rjones at redhat.com
Subject: libguestfs patch
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101


here is a patch for making libguestfs build more reproducibly

Bernhard M.

Index: libguestfs-1.26.10/generator/docstrings.ml
--- libguestfs-1.26.10.orig/generator/docstrings.ml
+++ libguestfs-1.26.10/generator/docstrings.ml
@@ -51,9 +51,7 @@ fact that they are deprecated indicates
 with correct use of these functions." prefix alt in
     Some txt

-let copyright_years =
-  let this_year = 1900 + (localtime (time ())).tm_year in
-  if this_year > 2009 then sprintf "2009-%04d" this_year else "2009"
+let copyright_years = "2009-2016"

 (* Generate a header block in a number of standard styles. *)
 type comment_style =

----- End forwarded message -----

I don't think I'd accept this as-is, but it would be OK if the final
year (ie. 2016) was placed in configure.ac, and passed to the
generator via a config.ml file.  This is because it's good to have all
the version / date stuff in one place, and that place is at the top of

Sadly we don't yet have a generator/config.ml{,.in} file, but one
could be easily created.


Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-p2v converts physical machines to virtual machines.  Boot with a
live CD or over the network (PXE) and turn machines into KVM guests.

More information about the Libguestfs mailing list