[Libguestfs] [PATCH] inspect: use os-release for CoreOS

Pino Toscano ptoscano at redhat.com
Thu Mar 31 09:42:13 UTC 2016


Hi,

On Thursday 31 March 2016 12:10:52 Nikos Skalkotos wrote:
> It looks good to me and it makes the code more robust. Removing
> /usr/lib/os-release in future releases of CoreOS is less probable than
> removing /usr/share/coreos/lsb-release.
> 
> After such a change I would also update
> `test-data/phony-guests/make-coreos-img.sh' to also inject an os-release
> file in the dummy image it creates. Find attached the
> `/usr/lib/os-release' and `/usr/share/coreos/lsb-release' of the latest
> stable CoreOS version to update the script accordingly.

Thanks.

I updated the patch to change the phony image as well, using the
current os-release, and pushed:
https://github.com/libguestfs/libguestfs/commit/d2e81b42e77edfb25c8cfd1db88fc2e4320da01b

-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20160331/316c8176/attachment.sig>


More information about the Libguestfs mailing list