[Libguestfs] [PATCH v3 04/11] launch: direct: Remove dead code promising we were going to use virtio-console.

Richard W.M. Jones rjones at redhat.com
Tue Mar 22 19:05:23 UTC 2016


We're never going to use virtio-console since, although it is faster,
it's not available during early boot, and that is more important for
debugging.
---
 src/launch-direct.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/src/launch-direct.c b/src/launch-direct.c
index a81d4b3..e8450e1 100644
--- a/src/launch-direct.c
+++ b/src/launch-direct.c
@@ -574,19 +574,9 @@ launch_direct (guestfs_h *g, void *datav, const char *arg)
   ADD_CMDLINE ("-device");
   ADD_CMDLINE (VIRTIO_SERIAL);
 
-#if 0
-  /* Use virtio-console (a variant form of virtio-serial) for the
-   * guest's serial console.
-   */
-  ADD_CMDLINE ("-chardev");
-  ADD_CMDLINE ("stdio,id=console");
-  ADD_CMDLINE ("-device");
-  ADD_CMDLINE ("virtconsole,chardev=console,name=org.libguestfs.console.0");
-#else
-  /* When the above works ...  until then: */
+  /* Create the serial console. */
   ADD_CMDLINE ("-serial");
   ADD_CMDLINE ("stdio");
-#endif
 
   if (qemu_supports_device (g, data, "Serial Graphics Adapter")) {
     /* Use sgabios instead of vgabios.  This means we'll see BIOS
-- 
2.7.4




More information about the Libguestfs mailing list