[Libguestfs] Proposal to start tagging releases in git with v<VERSION>

[Richard W.M. Jones]

For historical reasons that don't really matter now, we currently
tag all releases with just the version number, eg:

  commit 6b48977cb7100e4f214b189052d4f0bf61523d11 (HEAD -> master, tag: 1.33.26, origin/master, origin/HEAD)
  Author: Richard W.M. Jones <rjones at redhat.com>
  Date:   Tue May 3 14:49:59 2016 +0100

      Version 1.33.26.

Of course this isn't the way that git versions are normally tagged.
The normal convention is to use "v<VERSION>" (eg. "v1.33.26").

I propose that I start tagging new releases this way (see the patch
below).  This shouldn't be controversial.

The question is should I tag new releases with the "old style" tags?
I'd prefer not to.  Should I go back and add "v<VERSION>" tags to all
the old releases?  Again, I'd prefer not to, but could do that if
anyone thinks it's necessary.

Rich.

>From fe9493a5a0dd34d5f3ffc1f5dbe76a8724011225 Mon Sep 17 00:00:00 2001
From: "Richard W.M. Jones" <rjones at redhat.com>
Date: Tue, 3 May 2016 21:25:54 +0100
Subject: [PATCH] Tag versions with "v<VERSION>" instead of just the version
 number.

This is the normal convention used for tagging git releases.
---
 Makefile.am | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile.am b/Makefile.am
index f4520c8..cef9129 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -524,7 +524,7 @@ maintainer-commit:
 # Tag HEAD with current version (only for maintainer).
 
 maintainer-tag:
-	git tag -a $(VERSION) -m "Version $(VERSION) ($(BRANCH_TYPE))" -f
+	git tag -a "v$(VERSION)" -m "Version $(VERSION) ($(BRANCH_TYPE))" -f
 
 # Maintainer only: check EXTRA_DIST rule is complete.
 # (Note you must have done 'make dist')
-- 
2.7.4



-- 
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
virt-builder quickly builds VMs from scratch
http://libguestfs.org/virt-builder.1.html