[Libguestfs] [PATCH 1/2] inspection: Set package manager to "unknown" if parsing major version failed (RHBZ#1332025).

[Pino Toscano]

On Wednesday 04 May 2016 14:12:29 Richard W.M. Jones wrote:
> In cases where parsing the release file failed and so we have an
> obviously incorrect major version number, don't try to infer the
> package manager from the major version number.
> 
> In the bug report, parsing the /etc/redhat-release file of a CentOS
> 7.1 guest failed, so major version was set to 0, and the package
> manager was inferred as "up2date".  virt-customize then failed with a
> peculiar error:
> 
>   virt-customize: sorry, don't know how to use --install with the 'up2date' package manager
> 
> Instead this sets it to "unknown" which will cause virt-customize to
> fail with:
> 
>   virt-customize: --install is not supported for this guest operating system
> 
> which is (only very slightly) better.
> 
> Problem reported by novegin on IRC.
> ---

LGTM.

Thanks,
-- 
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20160504/1209d652/attachment.sig>