[Libguestfs] [PATCH 08/11] v2v: don't set spice display if QXL isn't supported

Cédric Bosdonnat cbosdonnat at suse.com
Thu May 12 13:29:16 UTC 2016


Setting spice display if we know the libvirt guest doesn't have QXL
capabilities will only make the guest slower for the user. Fallback
to VNC in such a case.

A typical use case is when v2v-ing a windows guest without having the
windows QXL driver at hand.
---
 v2v/output_libvirt.ml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/v2v/output_libvirt.ml b/v2v/output_libvirt.ml
index bedd6b4..1999600 100644
--- a/v2v/output_libvirt.ml
+++ b/v2v/output_libvirt.ml
@@ -239,7 +239,9 @@ let create_libvirt_xml ?pool source target_buses guestcaps
     | Some { s_display_type = VNC } ->
        e "graphics" [ "type", "vnc" ] []
     | Some { s_display_type = Spice } ->
-       e "graphics" [ "type", "spice" ] [] in
+       match guestcaps.gcaps_video with
+       | QXL ->    e "graphics" [ "type", "spice" ] []
+       | Cirrus -> e "graphics" [ "type", "vnc" ] [] in
 
   (match source.s_display with
    | Some { s_keymap = Some km } -> append_attr ("keymap", km) graphics
-- 
2.6.6




More information about the Libguestfs mailing list