[Libguestfs] [PATCH 1/2] Revert "appliance: init: run ldconfig"
Pino Toscano
ptoscano at redhat.com
Fri May 13 12:14:48 UTC 2016
On Thursday 12 May 2016 16:57:55 Richard W.M. Jones wrote:
> Running ldconfig adds about 100ms to the boot time. I would prefer
> that we understood which libraries need ldconfig to be run, and fix
> that. We could also consider running ldconfig in parallel, but since
> it might be required by just about any binary that the init script
> runs it's not clear what benefit that gives.
>
> This reverts commit 66aa98265dd215dcd4c717e7ef6845fbac859e54.
> ---
> appliance/init | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/appliance/init b/appliance/init
> index 413a95f..419434a 100755
> --- a/appliance/init
> +++ b/appliance/init
> @@ -17,10 +17,6 @@ if [ ! -d /tmp ] || [ ! -d /var/tmp ]; then
> chmod 1777 /tmp /var/tmp
> fi
>
> -# Make sure to find all the libraries, also those in non-standard place
> -# but with a proper ld.so configuration pointing at them
> -ldconfig
> -
> # Try to print a stack trace for segfaults inside the appliance.
> for d in /lib64 /lib; do
> f=$d/libSegFault.so
Seems to work fine, the series LGTM.
Thanks,
--
Pino Toscano
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://listman.redhat.com/archives/libguestfs/attachments/20160513/d3018eea/attachment.sig>
More information about the Libguestfs
mailing list